Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iris to Shader Mod check #1969

Closed
wants to merge 1 commit into from

Conversation

maxnoller
Copy link

Added iris to shader mod check

Fixes #1967

Added iris to shader mod check
@maxnoller maxnoller changed the title Add iris to Shader Mod check, fixes Fixes #1967 Add iris to Shader Mod check Sep 8, 2024
@Hex4dec
Copy link

Hex4dec commented Sep 8, 2024

Are you sure this is the correct fix? Note that you are adding the check to the Forge project, and Oculus is the Forge version of Iris. This shouldn't do anything.

Nevermind, seems like Iris natively supports NeoForge.

@maxnoller
Copy link
Author

I tested this in the ATM10 Modpack Alpha that uses Neoforge and Iris (I encountered the bug there) and this one line change fixed the problems and so far I have been playing for 4 hours with it and have not noticed any problems. I haven't touched MC modding in a long time so im not sure this is all that is needed. Also regarding the failed test, I dont think my code change caused this right? Should I still look into fixing that?

@Hex4dec
Copy link

Hex4dec commented Sep 8, 2024

No, pretty sure CC:T tests are a mess.

@Erb3
Copy link
Contributor

Erb3 commented Sep 8, 2024

(-14930832, -60, -4764970) Moved 32 items into a double chest
Expected: [<32>]
but: was null at -14930830,-58,-4764968 (relative: 2,2,2) (t=6)

Looks like a flaky test - not your fault.

@SquidDev
Copy link
Member

SquidDev commented Sep 11, 2024

Thank you for the PR! I'm afraid I ended up fixing this in a slightly different way (63181e7) — we no longer need the Oculus check at all, as Oculus doesn't support MC 1.21.

@SquidDev SquidDev closed this Sep 11, 2024
@maxnoller maxnoller deleted the maxnoller-patch-1 branch September 11, 2024 19:23
@maxnoller
Copy link
Author

okey that looks like a slightly more comprehensive way to deal with this issue than what I did. Thanks for dealing with this os fast, now I can finally create Bar-Chart galore in Minecraft again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants